-
Notifications
You must be signed in to change notification settings - Fork 8
WIP: Issue/3 New broken and redirected link rule #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add broken and redirected link rule
Add BrokenRedirectedLink to rules json
Add test checking that a redirect link is contained in metadata
Clean up docker testing components and comments
cidilabs
reviewed
Oct 13, 2021
Contributor
Author
|
Left to do @bagofarms:
|
Contributor
|
I took over from where Cris left off, since he will no longer be working on this. Major changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Broken and redirected link rule and test added. It uses the same logic as UDOIT 2.8.X to curl links. On detection of either broken or redirected link, the rule sets the anchor as an issue. In the redirected case, the new link ends up saved to the issue metadata.
Tests are for the baseline functions of: Is a non-redirected link detected as an issue (e.g., "https://google.com" not being flagged as redirected because the link changed to "https://www.google.com")? Is a redirected link detected? Is a broken link detected? Do redirected links save the new link to the metadata?