Skip to content

Fix assert.ErrorContains for nil error #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

Fix assert.ErrorContains for nil error #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion picotestify/assert/assert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ func ErrorContains(t TestingT, err error, contains string, msgAndArgs ...any) bo
return true
}

fail(t, msgAndArgs, "Error %q does not contain %q", err.Error(), contains)
if err == nil {
fail(t, msgAndArgs, "Expected error containing %q but got nil", contains)
} else {
fail(t, msgAndArgs, "Error %q does not contain %q", err.Error(), contains)
}

return false
}
Expand Down
5 changes: 5 additions & 0 deletions picotestify/assert/assert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ func TestAssert(t *testing.T) {
pass: func(t assert.TestingT) { assert.ErrorContains(t, errors.New("test error: check"), "error") },
fail: func(t assert.TestingT) { assert.ErrorContains(t, errors.New("test error: check"), "error2") },
},
{
name: "ErrorContains - nil",
pass: func(t assert.TestingT) { assert.ErrorContains(t, errors.New("test error: check"), "error") },
fail: func(t assert.TestingT) { assert.ErrorContains(t, nil, "error") },
},
{
name: "Empty",
pass: func(t assert.TestingT) { assert.Empty(t, []int{}) },
Expand Down
Loading