Cleanup #1
Open
Cleanup #1
+1,257
−16,071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19002832692Details
💛 - Coveralls |
Things that were removed: * Docker images * Executables * Blenc code * CinodeFS code * Datatore factory * Filesystem-based datastore * Web-based datastore * Multisource datastore
* Move datastore testsuite to separate package * Extract storage backend test suite * Move test vectors generation to sub-folder Preparation for using test vectors through embed * Add embedable version of test vectors That way testsvectors can be used without os package.
This implementation bases on existing bit.Int implementation of conversion to/from text representation of a given base. Two additional changes needed are for handling leading zeroes case which is unique to base58 and switching the alphabet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.