Skip to content

Add Open Source Policy #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 12, 2020
Merged

Add Open Source Policy #10

merged 7 commits into from
Mar 12, 2020

Conversation

felddy
Copy link
Contributor

@felddy felddy commented Mar 12, 2020

🗣 Description

Copied and slightly modified the open source policy from 18-F.
See: https://github.com/18F/open-source-policy

💭 Motivation and Context

We have new people publishing code to cisagov and they need to know this.

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felddy felddy added the documentation This issue or pull request improves or adds to documentation label Mar 12, 2020
@felddy felddy requested review from a team, dav3r, jsf9k and mcdonnnj as code owners March 12, 2020 20:36
@felddy felddy self-assigned this Mar 12, 2020
jsf9k
jsf9k approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a few minor comments. Nice work!

dav3r
dav3r approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's good enough for 18F, it's good enough for me! 📝

@felddy felddy merged commit 095b894 into develop Mar 12, 2020
@felddy felddy deleted the improvement/os-policy branch June 23, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@felddy felddy

Labels

documentation This issue or pull request improves or adds to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felddy @jsf9k @dav3r