Skip to content

terraform-to-secrets: Handle case where tags are None #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2020
Merged

terraform-to-secrets: Handle case where tags are None #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b49f6
Handle the case where the tags element exists, but it is set to None.
dav3r Apr 11, 2020
9954518
Make code a bit clearer and cleaner. Thanks to @felddy for the sugge…
dav3r Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion project_setup/scripts/terraform-to-secrets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,13 @@ def parse_tagged_resources(
) -> Generator[Tuple[str, str], None, None]:
"""Search all resources for tags requesting the creation of a secret."""
for resource in find_resources(terraform_state, None):
tags: Dict[str, str] = resource["values"].get("tags", dict())
# Ensure "tags" key exists in resource["values"] and if it does,
# make sure its value is not None. Both of these cases can occur.
tags: Dict[str, str]
if "tags" not in resource["values"] or resource["values"].get("tags") is None:
tags = dict()
else:
tags = resource["values"]["tags"]
secret_name: Optional[str] = tags.get(GITHUB_SECRET_NAME_TAG)
lookup_tag: Optional[str] = tags.get(GITHUB_SECRET_TERRAFORM_LOOKUP_TAG)
secret_value: str
Expand Down