terraform-to-secrets: Search for secrets in resource outputs #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates
terraform-to-secrets
so that it also searches for tagged secrets in resource outputs, such as with Terraform remote states.💭 Motivation and Context
In some cases, a secret is needed that was not created by the local Terraform code. An example of this is the Terraform test user in
nessus-packer
, which requires theid
of the "third-party" bucket created incool-accounts/images
. If we tag the bucket appropriately (incool-accounts/images
, then the code in this PR allows that secret to be discovered.🧪 Testing
To test this, I tagged the "third-party" bucket in Staging like so:
Then, I applied that change in Staging and verified that
terraform-to-secrets
was able to successfully detect the bucket name (id
) as a secret.📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist