Skip to content

Add label management instructions and default labels file #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Add label management instructions and default labels file #41

wants to merge 9 commits into from

Conversation

hillaryj
Copy link
Contributor

@hillaryj hillaryj commented Dec 15, 2020 •
edited
Loading

🗣 Description

Adds a how-to guide for standardizing labels across the organization and a file containing defaults.

Closes cisagov/.github#7

💭 Motivation and Context

Adds documentation for the label-standardization process plus default labels so we can do this again if we need to.

🧪 Testing

Linting passes; labels were successfully applied as per cisagov/.github#7

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@hillaryj hillaryj added the documentation This issue or pull request improves or adds to documentation label Dec 15, 2020
@hillaryj hillaryj self-assigned this Dec 15, 2020
jsf9k
jsf9k requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordered list that doesn't render correctly is the only holding back my approval. Everything else is less important.

hillaryj and others added 5 commits December 15, 2020 15:57
@hillaryj @jsf9k
Apply suggestions from code review
3c19766 
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
@hillaryj
Convert to pyenv and fix bullets
105129a
@hillaryj @jsf9k
Apply suggestions from code review
e89098d 
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
@hillaryj
Convert to pyenv continued
59da33d 
pyenv all the things
@hillaryj
Fix numbering and formatting
c6b0764 
Stop starting over at 1 all the time.
@hillaryj hillaryj requested a review from jsf9k December 15, 2020 21:29
jsf9k
jsf9k approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking all those nits! Great work!

dav3r
dav3r approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent - thanks @hillaryj for a great write-up! 📘

I only can offer two minuscule suggestions...

mcdonnnj
mcdonnnj approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this written up. I had some small consistency suggestions and nitpicks. Thanks again!

config/label-management.md
When you return to the directory in a new shell, remember to:

```console
pyenv activate github-label-management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've set up pyenv as we instruct in our CONTRIBUTING.md files (cisagov/skeleton-generic's as an example), then this step should not be necessary as long as the correct virtualenv has been set with pyenv local.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be resolved by moving to a skeletonized version in https://github.com/cisagov/github-label-management.

@hillaryj @dav3r @mcdonnnj
Apply suggestions from code review
2a038d6 
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
@hillaryj
Copy link
Contributor Author

After discussing with @mcdonnnj and for ease of future use, I've created https://github.com/cisagov/github-label-management which will host an updated and genericized version of this tool. I'm incorporating the feedback here into that project and will close this PR once I've gotten that up and running.

@hillaryj hillaryj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Dec 18, 2020
@hillaryj hillaryj added bogus and removed bogus labels Feb 18, 2021
@jsf9k
Copy link
Member

jsf9k commented Apr 12, 2023

@cisagov/team-ois, can we close this ancient PR?

@mcdonnnj
Copy link
Member

@cisagov/team-ois, can we close this ancient PR?

Shut 'er down. The repository reference in #41 (comment) has already been deleted as well.

@jsf9k
Copy link
Member

jsf9k commented Apr 12, 2023

Closing this ancient PR, as we already have automated label management via a GitHub Action inherited from cisagov/skeleton-generic.

@jsf9k jsf9k closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@felddy felddy Awaiting requested review from felddy

Assignees

@hillaryj hillaryj

Labels

blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standardize org-wide labels

4 participants

@hillaryj @jsf9k @mcdonnnj @dav3r