New tool to create GitHub secrets based on IAM creds extracted from Terraform state. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Update actions/checkout to v2 Update formatting to match downstream children
…n_and_checkout_action Update Python and actions/checkout Versions
Update pre-commit hooks (and flip Actions cache order in workflow).
… verbose '--requirement'.
…ches Use Verbose pip Switches
Autoupdate pre-commit hooks. Add mypy.
…provement/iam_to_github
Adds the ability to filter users. Adds better pre-launch checks. Adds ability to add suffixes to secret names.
felddy
requested review from
a team,
dav3r,
jsf9k and
mcdonnnj
as code owners
jsf9k
approved these changes
Feb 23, 2020
dav3r
approved these changes
Feb 24, 2020
mcdonnnj
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add the
iam-to-githubtool. Creates GitHub secrets for use in GitHub Actions.💭 Motivation and Context
We have a similar tool for our previous CI (Travis).
Terraform no longer displays the secret keys in show state.
This is a nice thing to have.
Features:
--repooption.handle those nicely. If more than one user is found it will inform the user how to proceed.
--useroption to be used to filter users down to one. And a--suffixoption that can modify the names used to store secrets.🧪 Testing
I tested this on a personal repository as well as cisago
v/ansible-role-dev-ssh-access
(@dav3r I may have clobbered any secrets you put out there. If the terraform state changed since we debugged it.)
📷 Screenshots (if appropriate)
Don't worry I rolled the key in the screenshot before I posted the image. 😛
🚥 Types of Changes
✅ Checklist