Skip to content

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Mar 8, 2020

🗣 Description

This PR adds boto3 to the set of required libraries for this project.

💭 Motivation and Context

I attempted to run the ssm-param script and realized that boto3 was not installed in my pyenv for this project, so this PR rectifies that.

🧪 Testing

I ran pip install --requirement requirements-dev.txt and confirmed that boto3 was indeed installed. I also ran ssm-param --help to verify that it was no longer complaining about boto3 being missing.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dav3r dav3r requested review from a team, felddy, jsf9k and mcdonnnj as code owners March 8, 2020 21:47
@dav3r dav3r self-assigned this Mar 8, 2020
@dav3r dav3r added the bugfix label Mar 8, 2020
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me ✔

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I'm not sure how this was missing for so long. That ssm-param script has been around awhile. I take full responsibility. Twenty-one lashes with a wet noodle. 🍜

@dav3r dav3r merged commit 46933f0 into develop Mar 9, 2020
@dav3r dav3r deleted the improvement/add_boto3_as_requirement branch March 9, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants