This repository was archived by the owner on Aug 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
⚠️ CONFLICT! Lineage pull request for: skeleton #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook performs auto-formatting (beautifying) of Bash scripts.
us-cert.gov now forwards to us-cert.cisa.gov, and since NCATS is a pre-CISA designation it makes sense to update this URL. The URL points to a specific set of services offered that does not encompass everything that is hosted in the cisagov org on GitHub. We have chosen the page describing CISA's cybersecurity mission as the best replacement URL.
We no longer have access to the old email address. Additionally the agency has gotten it's own email domain, so we prefer cisa.dhs.gov addresses at this point.
The download_urls field was being used incorrectly, as it is supposed to provide a download URL to a file usable to install the package. This would typically be a tarball of some kind. Additionaly this field is discouraged per pypa/packaging.python.org#293, so we should stop using it in our package metadata. The best replacement I found is the project_urls field, which allows us to provide a number of purpose specific URLs about the package.
The v5 release of ansible-lint introduces breaking changes, so we are holding off on updating until things are resolved. Conversation about this can be tracked in cisagov/skeleton-ansible-role#69.
Update pre-commit Hooks
…it_hook Add the beautysh pre-commit hook
Lineage pull request for: skeleton
…rements Add the mypy Package to the Development Package Requirements
Update Package Metadata
⚠️ CONFLICT! Lineage pull request for: skeleton
This pull request introduces 1 alert when merging c227af6 into 9acf38d - view on LGTM.com new alerts:
|
c227af6
to
0036ea0
Compare
dav3r
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚎
jsf9k
approved these changes
Mar 3, 2021
mcdonnnj
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-aws-lambda.git
Remote branch:
HEAD
Check the changes in this pull request to ensure they won't cause issues with
your project.
The
lineage/skeleton
branch has one or more unresolved merge conflictsthat you must resolve before merging this pull request!
How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
status
command. Fix any conflicts andpossibly incorrect auto-merges.
After resolving each of the conflicts,
add
your changes to thebranch,
commit
, andpush
your changes:Note that you may append to the default merge commit message
that git creates for you, but please do not delete the existing
content. It provides useful information about the merge that is
being performed.
Wait for all the automated tests to pass.
Check the "Everything is cool" checkbox below:
Mark this draft pull request "Ready for review".
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml
📚 Read more about Lineage