Add configurable logging for Lambda invocations #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
dav3r
approved these changes
Feb 8, 2023
jsf9k
approved these changes
Feb 8, 2023
Add the ability to configure the logging level for a given invocation of the Lambda. We use an environment variable to also highlight how a Lambda might be configured to run with a specific configuration. This environment variable will change the logging level for a given invocation of the Lambda and then reset it to the previous level.
The `semver` package was not in the develop requirements even though it is required by the bump_version.sh script.
jmorrowomni
force-pushed
the
improvement/allow_configurable_logging
branch
from
5669883 to
16901db
Compare
jsf9k
approved these changes
Mar 2, 2023
dav3r
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds the ability to configure the logging level for a Lambda invocations by setting the
log_levelenvironment variable in its environment. It also adds a missing development dependency.⚠ Note
This is built on top of the current
lineage/skeletonbranch to ease merging.💭 Motivation and context
Providing a way to change logging level (notably for debugging) is good to have for any tool. Since you may only want it for a single invocation or period of time it makes sense to adjust it on a per-invocation basis.
We need the semver package to successfully use the
bump_version.shscript.🧪 Testing
Automated tests pass. I started the image locally and checked that appropriate logging messages were in the Compose logs based on the configuration given to the image.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist