Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Mar 6, 2020

🗣 Description

This PR pulls in upstream changes from cisagov/skeleton-python-library that include a fix for a potential pre-commit issue in GitHub Actions and the addition of the mypy hook for pre-commit. The output file skeleton-aws-lambda.zip is also belatedly added to .gitignore.

💭 Motivation and Context

Being an up-to-date repository is good.

🧪 Testing

The automagical kind.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

felddy and others added 14 commits February 20, 2020 17:29
Add static type checking to the Python skeleton
This should resolve the issue seen when the Python version changes before there
is an update to .pre-commit-config.yml which results in pre-commit pointing to
a non-existent Python installation.
Incorporate the Python version into keys for pip and pre-commit caches.
Pull in Fix for pre-commit Caching from Upstream
@mcdonnnj mcdonnnj requested review from a team, dav3r, felddy and jsf9k as code owners March 6, 2020 15:12
@mcdonnnj mcdonnnj self-assigned this Mar 6, 2020
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛋

@mcdonnnj mcdonnnj merged commit 43f0c4d into develop Mar 6, 2020
@mcdonnnj mcdonnnj deleted the improvements/pull_in_upstream_changes branch March 6, 2020 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants