This repository was archived by the owner on Dec 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Pull in Upstream Changes #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add static type checking to the Python skeleton
Autoupdate pre-commit hooks. Add mypy.
…ignore Add .mypy_cache to .gitignore
This should resolve the issue seen when the Python version changes before there is an update to .pre-commit-config.yml which results in pre-commit pointing to a non-existent Python installation.
Incorporate the Python version into keys for pip and pre-commit caches.
…gfix/pull_in_pre-commit_fix
Pull in Fix for pre-commit Caching from Upstream
…into improvements/pull_in_upstream_changes
jsf9k
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dav3r
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛋
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR pulls in upstream changes from cisagov/skeleton-python-library that include a fix for a potential
pre-commit
issue in GitHub Actions and the addition of themypy
hook forpre-commit
. The output fileskeleton-aws-lambda.zip
is also belatedly added to.gitignore
.💭 Motivation and Context
Being an up-to-date repository is good.
🧪 Testing
The automagical kind.
📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist