Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Feb 17, 2021

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-python-library.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/skeleton-aws-lambda.git skeleton-aws-lambda
    cd skeleton-aws-lambda
    git remote add skeleton https://github.com/cisagov/skeleton-python-library.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add setup.py 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 19 commits January 15, 2021 10:36
This hook performs auto-formatting (beautifying) of Bash scripts.
us-cert.gov now forwards to us-cert.cisa.gov, and since NCATS is a pre-CISA
designation it makes sense to update this URL. The URL points to a specific
set of services offered that does not encompass everything that is hosted in
the cisagov org on GitHub. We have chosen the page describing CISA's
cybersecurity mission as the best replacement URL.
We no longer have access to the old email address. Additionally the agency
has gotten it's own email domain, so we prefer cisa.dhs.gov addresses at
this point.
The download_urls field was being used incorrectly, as it is supposed to
provide a download URL to a file usable to install the package. This would
typically be a tarball of some kind. Additionaly this field is discouraged
per pypa/packaging.python.org#293, so we should
stop using it in our package metadata. The best replacement I found is the
project_urls field, which allows us to provide a number of purpose specific
URLs about the package.
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
Lineage pull request for: skeleton
…rements

Add the mypy Package to the Development Package Requirements
@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2021

This pull request introduces 1 alert when merging 54597cb into f00cf3c - view on LGTM.com

new alerts:

  • 1 for Syntax error

@mcdonnnj mcdonnnj added the upstream update This issue or pull request pulls in upstream updates label Feb 17, 2021
@mcdonnnj mcdonnnj marked this pull request as ready for review February 26, 2021 16:59
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀 🐑

@mcdonnnj mcdonnnj merged commit d065768 into develop Mar 1, 2021
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch March 1, 2021 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

upstream update This issue or pull request pulls in upstream updates

Projects

Development

Successfully merging this pull request may close these issues.

6 participants