Skip to content

Conversation

navhaxs
Copy link
Contributor

@navhaxs navhaxs commented Oct 12, 2016

Corrected the example snippets to use the correct names in super() to match the class name, and also added the missing super call in "pre_test"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.643% when pulling 88aa15c on navhaxs:server-fuzzing-docs-patch-1 into 7f8b945 on cisco-sas:master.

@BinyaminSharet
Copy link
Member

@navhaxs thanks for the PR! Really appreciated. Could you please re-submit it to the next branch?

@BinyaminSharet
Copy link
Member

@navhaxs Changing the pull request target branch should be easy now, see here: https://github.com/blog/2224-change-the-base-branch-of-a-pull-request

@navhaxs navhaxs changed the base branch from master to next October 12, 2016 12:27
@navhaxs
Copy link
Contributor Author

navhaxs commented Oct 12, 2016

Sure, very easy 👍

Copy link
Member

@BinyaminSharet BinyaminSharet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added a call to super in pre_test in line 420, but you call there to post_test of super in stead of pre_test. Please fix it.
just add another commit, and it will automatically update the pull request.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.643% when pulling ee2d2b1 on navhaxs:server-fuzzing-docs-patch-1 into a1d7a96 on cisco-sas:next.

@navhaxs
Copy link
Contributor Author

navhaxs commented Oct 12, 2016

Apologies, I've corrected that. Also noticed and fixed another typo.

@BinyaminSharet BinyaminSharet merged commit dfb8ac6 into cisco-sas:next Oct 12, 2016
@BinyaminSharet
Copy link
Member

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants