Set host_reachability correctly when setting ingress_replication #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
rahushen
reviewed
May 7, 2018
| # Note: ingress-replication is not supported on all platforms. | ||
| # Use to_s.empty check to also handle nil check. | ||
| if ingress_replication.to_s.empty? | ||
| set_host_reachability(@set_args[:name], protocol) |
There was a problem hiding this comment.
Maybe move this before if/else as it is exercised in both code paths
There was a problem hiding this comment.
Actually.. I tested it and it fails if I move it out of the if/else block. The reason is that the two lines in the else block have to be executed first.
There was a problem hiding this comment.
would this work?
unless ingress_replication.to_s.empty?
set_args_keys(state: 'no', protocol: ingress_replication)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
end
set_host_reachability(@set_args[:name], protocol)
set_args_keys(state: '', protocol: protocol)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
There was a problem hiding this comment.
Yup. That works. Thanks for the suggestion.
|
@mikewiebe .. Minor comment. Otherwise 👍 |
rahushen
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In later versions of Nexus, the vxlan vtep host reachability must be set properly before setting the ingress replication feature.
This update modified the
ingress_replicationsetter to check the should intent forprotocoland ensures that the vtep host reachability is set properly to support the protocol setting.Testing:
Tests pass on n7k, n9k(latest, greensboro, freeport and camden), n9k-fretta)