Skip to content

Set host_reachability correctly when setting ingress_replication #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2018
Merged

Set host_reachability correctly when setting ingress_replication #581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0dbb94
Set host_reachability correctly when setting ingress_replication
mikewiebe May 7, 2018
e3a4ca2
Review comments
mikewiebe May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions lib/cisco_node_utils/vxlan_vtep_vni.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,33 @@ def ingress_replication
config_get('vxlan_vtep_vni', 'ingress_replication', @get_args)
end

def set_host_reachability(vtep_name, protocol)
# This is a helper method for the ingress_replication setter.
# In later versions of Nexus, a check was added to make sure
# the host_reachability setting is correct for the desired
# ingress_replication setting.
#
case protocol
when 'bgp'
host_reachability = 'evpn'
when 'static'
host_reachability = 'flood'
else
fail "Protocol #{protocol} currently not supported"
end
VxlanVtep.new(vtep_name).host_reachability = host_reachability
end

def remove_add_ingress_replication(protocol)
# Note: ingress-replication is not supported on all platforms.
# Use to_s.empty check to also handle nil check.
if ingress_replication.to_s.empty?
set_args_keys(state: '', protocol: protocol)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
else
# Sadly, the only way to change between protocols is to
# first remove the existing protocol.
unless ingress_replication.to_s.empty?
set_args_keys(state: 'no', protocol: ingress_replication)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
set_args_keys(state: '', protocol: protocol)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
end
set_host_reachability(@set_args[:name], protocol)
set_args_keys(state: '', protocol: protocol)
config_set('vxlan_vtep_vni', 'ingress_replication', @set_args)
end

def ingress_replication=(protocol)
Expand Down