WolfSSL aes icm multi encrypt fix #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libSRTP will allocate and initialize a cipher once and then use it to encrypt or decrypt multiple packets. Between each operation a new IV will be set, the IV is unique for each packet. This test will ensure that cipher implementations support this. The test vectors are based on examples in RFC 9335 .
When building using wolfssl on Apple silicon and armasm enabled, a call to wc_AesSetIV was not enough to reset the context between each operation. Calling wc_AesSetKey will reset it but may incur a performance penalty.
|
@SparkiDev could you please review this PR since you added the wolfssl integration, thanks! |
SparkiDev
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current wolfssl integration fails to encrypt multiple packets correctly on Apple silicon with "--enable-armasm".
A multi packet test is added to cipher_driver to verify this.
libSRTP will allocate and initialize a cipher once and then use it to encrypt or decrypt multiple packets. Between each operation a new IV will be set, the IV is unique for each packet. This test will ensure that cipher implementations support this.
The test vectors are based on examples in RFC 9335 .