Skip to content

Conversation

@caidanw
Copy link

@caidanw caidanw commented Sep 27, 2023

I noticed a small bug in the SuperDebug component when it is included as a child of a <form> element. The bug is that when you click the collapse button it will try to submit the form, which I don't think is intended behaviour.

This patch just adds the preventDefault event modifier to the on:click button event.

For anyone that isn't familiar with the preventDefault modifier, all it does is call event.preventDefault() before running the handler. docs

@ciscoheat ciscoheat merged commit 5fbe4d3 into ciscoheat:main Sep 28, 2023
@ciscoheat
Copy link
Owner

Thank you, glad to know it's being used.

@ciscoheat
Copy link
Owner

Just released 1.7.3 now with this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants