Add a mask to orcid field #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR629/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR629/ |
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR629/ |
Collaborator
Author
|
Thanks for the review 🐦 |
abelsiqueira
changed the title
This was referenced Aug 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
The orcid now has a mask that only permits writing the numbers (and X at the end).
To not write the mask to the cff object, I added a condition on setAuthorField.
I removed the hint and label, since they are unnecessary now.
This is the empty field:
Instructions to review the pull request
Use the preview to try to break the orcid field. Try pasting the full URL, and just the id.