Resizing reset button #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR677/ |
Collaborator
|
@recap, can you fix the title and description of the Pull Request, please? Check the template and other PRs as examples. |
abelsiqueira
approved these changes
Aug 24, 2022
Collaborator
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Thanks for the pull request. After merging this, can you create another issue about the button size for mobile?
I think we can use something like
v-bind:class="$q.platform.is.mobile ? 'full-width' : ''"on the DownloadButton component. Ref: https://quasar.dev/options/platform-detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Resizing reset button
Instructions to review the pull request