[CIVIS-11019] update to use ubuntu 22.04 fips enabled base image #1
Conversation
- Use consistent 2-space indentation throughout - Remove unnecessary comment blocks - Better organize ARG declarations - Improve line continuation formatting 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
- Add docker-compose.yml with build args for VERSION and CODE_RELEASE - Add .env.example with configurable environment variables - Update .gitignore and .dockerignore to exclude .env files - Set CODE_RELEASE default to 4.102.1 for stable builds - Configure image name: gabemendoza1/codecloud-code-server 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
There was a problem hiding this comment.
Pull Request Overview
This pull request creates an Ubuntu FIPS variant of the docker-code-server project. The PR removes the standard LinuxServer.io configuration files and replaces them with a custom FIPS-compliant base image, while adding a Docker Compose configuration for local development.
Key changes:
- Removes LinuxServer.io templated files and Jenkins CI configuration
- Switches base image to a FIPS-compliant Ubuntu variant
- Adds Docker Compose setup for development workflow
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| readme-vars.yml | Removes LinuxServer.io readme configuration |
| package_versions.txt | Removes package version tracking file |
| jenkins-vars.yml | Removes Jenkins pipeline configuration |
| docker-compose.yml | Adds Docker Compose configuration for local development |
| Jenkinsfile | Removes LinuxServer.io Jenkins pipeline |
| Dockerfile.aarch64 | Removes ARM64 Dockerfile variant |
| Dockerfile | Updates to use FIPS-compliant base image and modifies configuration |
| .github/PULL_REQUEST_TEMPLATE.md | Updates PR template to use civisanalytics standards |
| .dockerignore | Adds .env file to ignore list |
thatguyinabeanie
changed the title
🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
leanne73
left a comment
leanne73
left a comment
There was a problem hiding this comment.
One question for my own curiosity (I assume it's something to do with python 3.12 though). LGTM
| curl -fsSL https://keyserver.ubuntu.com/pks/lookup?op=get\&search=0xF23C5A6CF475977595C89F51BA6932366A755776 | apt-key add - && \ | ||
| echo "deb https://ppa.launchpadcontent.net/deadsnakes/ppa/ubuntu jammy main" > /etc/apt/sources.list.d/deadsnakes.list && \ |
There was a problem hiding this comment.
so ubuntu 22 doesnt know where to install python 3.12 from. this tells apt-get where to install python 3.12 from
There was a problem hiding this comment.
love that python lives in deadsnakes 😆
|
Pull Request Merged!!! This build is running now. |
3 participants
Associated PRs
Description
Required: Please provide a brief description of what this pull request is trying to accomplish.
Context, Consequences, & Considerations
Required: Please step through the following list, pausing at each item to consider your change in relation to the item's context.
Check the box to mark that it applies, and enter your relevant notes under the item.
securitylabel to this PR then request a review from the Security Code Reviewers Team.