Remove NPM hooks #164
Merged
Remove NPM hooks #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I have tested and it worked in my fork https://www.npmjs.com/package/@hoangvvo/react-native-spotify-remote |
Collaborator
Author
|
I just notice this technically undo https://github.com/cjam/react-native-spotify-remote/pull/157/files. I am not sure the intention in that PR so we may need to consider that. |
Owner
|
Yea this seems like a good change. All of the necessary files should be packaged up in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is in #162 (comment)
postinstallhook requires user to installyarnand use a Linux-base machine (because ofrm -rfcommand)postpackdoes not really do anything because it is run after the tarball is generated