Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit be98aa4

Browse files
committed
Other: Replace getResizeObserver helper with new ResizeObserver class in ToolbarView.
Follow-up on: ckeditor/ckeditor5-utils/pull/320
1 parent a6b9c09 commit be98aa4

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/toolbar/toolbarview.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';
1414
import FocusCycler from '../focuscycler';
1515
import KeystrokeHandler from '@ckeditor/ckeditor5-utils/src/keystrokehandler';
1616
import ToolbarSeparatorView from './toolbarseparatorview';
17-
import getResizeObserver from '@ckeditor/ckeditor5-utils/src/dom/getresizeobserver';
17+
import ResizeObserver from '@ckeditor/ckeditor5-utils/src/dom/resizeobserver';
1818
import preventDefault from '../bindings/preventdefault.js';
1919
import Rect from '@ckeditor/ckeditor5-utils/src/dom/rect';
2020
import global from '@ckeditor/ckeditor5-utils/src/dom/global';
@@ -494,7 +494,7 @@ class DynamicGrouping {
494494
* **Note:** Created in {@link #_enableGroupingOnResize}.
495495
*
496496
* @readonly
497-
* @member {module:utils/dom/getresizeobserver~ResizeObserver}
497+
* @member {module:utils/dom/resizeobserver~ResizeObserver}
498498
*/
499499
this.resizeObserver = null;
500500

@@ -580,7 +580,7 @@ class DynamicGrouping {
580580
// so let's make sure it's actually destroyed along with the toolbar.
581581
this.groupedItemsDropdown.destroy();
582582

583-
this.resizeObserver.disconnect();
583+
this.resizeObserver.destroy();
584584
}
585585

586586
/**
@@ -683,16 +683,14 @@ class DynamicGrouping {
683683
let previousWidth;
684684

685685
// TODO: Consider debounce.
686-
this.resizeObserver = getResizeObserver( ( [ entry ] ) => {
686+
this.resizeObserver = new ResizeObserver( this.viewElement, entry => {
687687
if ( !previousWidth || previousWidth !== entry.contentRect.width ) {
688688
this._updateGrouping();
689689

690690
previousWidth = entry.contentRect.width;
691691
}
692692
} );
693693

694-
this.resizeObserver.observe( this.viewElement );
695-
696694
this._updateGrouping();
697695
}
698696

0 commit comments

Comments
 (0)