Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Initialize CommitterMap with empty default properties#29

Merged
ibakshay merged 1 commit intocontributor-assistant:masterfrom
mmv08:cannot-read-property-push-of-undefined
Aug 5, 2020
Merged

Initialize CommitterMap with empty default properties#29
ibakshay merged 1 commit intocontributor-assistant:masterfrom
mmv08:cannot-read-property-push-of-undefined

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented Aug 4, 2020

This PR:

The problem was that if a pull request included a commit from user with no github account, it would try to push the user object to committersMap.unknown but unknown array was not preinitialised and thus undefined

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 4, 2020

CLA assistant check
All committers have signed the CLA.

@ibakshay ibakshay self-assigned this Aug 5, 2020
@ibakshay ibakshay merged commit cd9ca69 into contributor-assistant:master Aug 5, 2020
@ibakshay
Copy link
Copy Markdown
Member

ibakshay commented Aug 5, 2020

@mikheevm, That is a great catch 💯 . Thank you very much :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read property 'push' of undefined

3 participants