added quickchart and mongodb#226
Conversation
a876e0d to
7dd0e5c
Compare
|
Dear @RafflesiaKhan - first of all, thank you so much for your contributions! Here are some things which need to be done before the new code can be merged, otherwise C3 (the CLAIMED component compiler) will fail to create (docker) container images, kubeflow components and CLI support - which usually happens automatically
|
4e96d58 to
83400f2
Compare
|
Dear @RafflesiaKhan just had a look at your latest commit - we're making progress, please note that the correct way to 'ingest' configuration parameters is by reading the environment variables so instead of
you can write database_username = os.environ.get('database_username', 'HERE_GOES_A_POTENTIAL_DEFAULT_VALUE') data_dir is not needed anymore Please have a look at the template notebook I've provided above, there is a code section which also needs to be added to be able to also 'ingest' configuration parameters via command line arguments |
@romeokienzler Thanks you so much for the comments, sorry I missed the code section, will update the PR soon |
8a100e4 to
37e1572
Compare
|
Thanks @RafflesiaKhan for the updates I think we are almost there In this file I think you don't need any default values for the parameters as there are no defaults, an example of a default value would be 5432 as postgesql port or so so you can change document = os.environ.get('document', 'HERE_GOES_YOUR_DATABASE_DOCUMENT') to document = os.environ.get('document') ...and so on, you can also delete the following:
|
|
In this file you have two cells with env parameters, can you please move eveything to the first one? |
|
Hi @romeokienzler , Thank you so much for the details instructions, I have tried to modify the code accordingly, not sure if it's ok now or not, please feel free to add comments for improvements. I have added 3 scripts and some other files got generated, are those related to the docker image, or it can be me merging incorrectly 🙄🫣 , still learning about the working procedure of the project, please let me if you have any idea about this, in either case, I can try to fix that. |
0d2cf57 to
19adc26
Compare
|
Hi @romeokienzler, Thank you so much for the detailed comments; those helped a lot; sorry about all these issues; thanks for being patient. I promise future PRs will be much cleaner 🙂. Please feel free to add comments if any other updates are required here. |
c569148 to
cac1273
Compare
|
Hi @romeokienzler, sorry got busy with office work, I have removed the |
|
Thanks so much @RafflesiaKhan I think you are almost done. The last thing missing is to remove the 2nd parameter of <> calls to the 'get' function in os.environ.get so instead of cluster_url = os.environ.get('cluster_url',"HERE_GOES_YOUR_CLUSTER_URL") please write cluster_url = os.environ.get('cluster_url') The 2nd parameter to that 'get' function is only there in case the environment variable is not set that there will be a default value set. So please go ahead and remove the 2nd parameter in ALL the function calls in ALL the notebooks you have provided and then I think we are good. One last thing, the CLAIMED component compiler doesn't support multi line comments for the parameters, so instead of you should write and of course also remove the 2nd parameter |
92c71f5 to
f4a35b4
Compare
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
This reverts commit 0fc561e. Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
…scripts added mondodb and quickchart scripts Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
text updated Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
Signed-off-by: Rafflesia Khan <rafflesiakhan.nw@gmail.com>
…Khan/component-library into add-mondodb-connection
|
Hi, @romeokienzler, Thank you. I have removed the 2nd parameter and 2 line comments. |
|
Thanks so much @RafflesiaKhan - great work - you are now an official contributor to an IBM sponsored Linux Foundation AI project [x] merged |
Yeaaaaaa 😎. I truly appreciate your encouragement, @romeokienzler! It has been such an amazing experience so far and I'm looking forward to continuing my journey as a contributor. Thank you so much for your support! 🙂 |


What changes were proposed in this pull request?
I have added three new scripts
How was this pull request tested?
These files are tested locally, and they are just making connection and printing data I am not certain which kind of test case I can add here, but I am happy to get any suggestions.
Developer's Certificate of Origin 1.1