OlgaTPark/tenfourfox#14 — Add a Keyboard Shortcut to Reader Mode #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes discussed in OlgaTPark#14 needed to add a keyboard shortcut to Reader Mode (the patches are based on PowerPC TenFourFox FPR6 because I tested them in OlgaFox FPR6).
This commit doesn't include M1438308 which changes the shortcut on Windows to
F9
.I also didn't included M1480415 which concerns a Windows screen reader that cannot "see" the reader button in the toolbar (but I doesn't expect a better situation on Mac OS X).
If you want, I can also add the changes for the
pdfjs.display.use_document_fonts=true
setting to this pull request.Concerning localizations, two files are affected:
OlgaTPark@8c65cb0#diff-38fb3065c40acfe9cd97e7cd67908052R102-R113
/browser/locales/en-US/chrome/browser/browser.dtd
(which ends up in
{TenFourFox.app/Content/Resources}/browser/chrome/en-US/locale/browser/browser.dtd
).Here, the change is the same for every locale (checked in Mozilla XPIs).
And:
OlgaTPark@8c65cb0#diff-0b08792398c408a93dd2a72b4b61cab5L286-L295
/browser/locales/en-US/chrome/browser/browser.properties
(which ends up in
{TenFourFox.app/Content/Resources}/browser/chrome/en-US/locale/browser/browser.properties
).I extracted the translated strings for every locale supported by TenFourFox from http://ftp.mozilla.org/pub/firefox/releases/60.0/mac/xpi/:
reader-mode-button.tooltip=Leseansicht umschalten (%S)
reader-mode-button.tooltip=Toggle reader view (%S)
reader-mode-button.tooltip=Cambiar vista de lectura (%S)
reader-mode-button.tooltip=Näytä/piilota lukunäkymä (%S)
reader-mode-button.tooltip=Activer/Désactiver le mode lecture (%S)
reader-mode-button.tooltip = Attiva/disattiva Modalità lettura (%S)
reader-mode-button.tooltip=읽기 모드 토글(%S)
reader-mode-button.tooltip=Przełącz poprawianie czytelności (%S)
reader-mode-button.tooltip=Включить/отключить Вид для чтения (%S)
reader-mode-button.tooltip=Växla läsvy (%S)
reader-mode-button.tooltip=Okuyucu görünümünü aç/kapat (%S)
reader-mode-button.tooltip=切换阅读器视图 (%S)
And for my forgiveness, I can already translate the strings from #328 (comment) in French:
grep
ed it in the localizations to see if it's already somewhere else and I've found:TenFourFox.app/Contents/Resources/chrome/fr/locale/fr/cookie/cookieAcceptDialog.properties
:domainColon=Domaine :
TenFourFox.app/Contents/Resources/browser/chrome/fr/locale/fr/devtools/client/netmonitor.dtd
:<!ENTITY netmonitorUI.toolbar.domain "Domaine">
TenFourFox.app/Contents/Resources/browser/chrome/fr/locale/browser/preferences/cookies.dtd
:<!ENTITY props.domain.label "Hôte :">
(This variant has a « Hostname » meaning)