[Feat] Cross-task mention and artifact reference via @ picker#154
Merged
[Feat] Cross-task mention and artifact reference via @ picker#154
Conversation
…cker Replace FilePicker with tab-based MentionPicker supporting two mention types: Tasks (injects full conversation context) and Files (workspace artifacts). Tab key switches sections, arrow keys navigate, Enter selects. Includes 500KB size guard on task context and dedup on selection.
Contributor
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the single-purpose FilePicker with a tab-based MentionPicker that supports two mention types: Tasks (injects full conversation context excluding tool calls) and Files (workspace artifacts from the file manager). Type
@in the chat input to open the picker, then use Tab to switch sections, arrow keys to navigate, and Enter to select.Type of change
[Feat]new feature[UI]UI or UX changeWhy is this needed?
Users need to reference other task conversations and workspace files as input context when composing messages. Previously, the
@picker only supported files from manually-added context folders. This replaces it with a unified mention system that can reference tasks (pulling their full conversation history) and artifacts from the file management system.What changed?
MentionPicker.tsx: Tab-based picker component (Tasks | Files) with keyboard navigation hints, artifact loading fromfileStore, and extensibleTABSarray for future mention typesFilePicker.tsx: Deleted — all functionality migrated to MentionPickerChatInput.tsxrework: NewselectedTasks/selectedArtifactsstate; unifiedcommitMention()handler;handleSendloads full conversation history for mentioned tasks (user+assistant messages, no tool calls) with 500KB size guard; artifact content read viareadArtifactFile; default tab based on artifact availabilityArchitecture impact
loadMessages,readArtifactFile,listArtifacts)docs/architecture-invariants.md: noneValidation
pnpm typecheckpnpm testpnpm buildRelease note
Checklist
[Feat]