Conversation
Contributor
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
986cb23 to
6d6459e
Compare
…t toggle - Add ja, ko, fr, de, es, pt translations to all I18nText objects across slides.md and 16 Vue components (~200 translation keys) - Change colorSchema from 'dark' to 'all' to re-enable Slidev's built-in dark/light theme toggle - Replace French ASCII apostrophes with Unicode U+2019 to fix Slidev title-renderer compilation errors Signed-off-by: samzong <samzong.lu@gmail.com>
6d6459e to
b270e5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add complete translations for all 8 supported languages (en, zh, ja, ko, fr, de, es, pt) across the entire keynote presentation, and restore the dark/light theme toggle that was previously disabled.
Type of change
[Feat]new featureWhy is this needed?
The keynote language switcher advertised 8 languages but only en and zh had actual translations — selecting ja/ko/fr/de/es/pt all fell back to English. Additionally, the
colorSchema: darksetting locked the presentation to dark mode only, removing the previously working theme toggle.What changed?
I18nTextobject acrossslides.mdand all 16 Vue components (~200 translation keys, ~1200 new translation values)colorSchemafromdarktoallin slides.md frontmatter to re-enable Slidev built-in dark/light toggle') with Unicode U+2019 ('’) to fix Slidev title-renderer Vue compilation errors (e.g.Qualité d'ingénieriebroke template parsing)Architecture impact
docs/architecture-invariants.md: noneLinked issues
N/A
Validation
pnpm dev(keynote) — all 8 languages render correctlypnpm lintpnpm testpnpm buildpnpm check:ui-contractScreenshots or recordings
N/A — keynote presentation changes only, no desktop UI affected.
Release note
NONE.Checklist
[Feat]