[Feat] Design system premium token layer — glass, glow, ambient, typography, motion presets#200
Merged
[Feat] Design system premium token layer — glass, glow, ambient, typography, motion presets#200
Conversation
Contributor
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
2d2ef0f to
82d2f44
Compare
…typography, motion presets Signed-off-by: samzong <samzong.lu@gmail.com>
82d2f44 to
2c04dae
Compare
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c04daeb44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the complete premium visual token layer that all subsequent UI worktrees depend on. Defines glass surfaces, 3-layer glow system, tool colors, ambient orbs, gradient tokens, display typography (Instrument Serif), extended motion presets, and CI enforcement rules — all with dark + light theme coverage and reduced-motion /
@supportsfallbacks.Type of change
[Feat]new feature[UI]UI or UX changeWhy is this needed?
The parallel UI upgrade worktrees (
ui--primitives-glass,ui--leftnav-premium,ui--chat-components, etc.) all need a shared token vocabulary. Without this foundation, each worktree would invent its own glass/glow/ambient values, leading to inconsistency and merge conflicts. This PR establishes the single source of truth.What changed?
.glass,.glass-heavy,.glass-card,.glass-command),.noise::afterpseudo-element, glow utilities (.glow-3,.glow-focus,.glow-selected,.glow-running),@supportsfallback for non-backdrop-filter browsers, 7 keyframes (ambient-drift-1/2/3,stream-pulse,bar-bounce,tool-scan,glow-pulse). All tokens have both dark and light theme definitions.@fontsource/instrument-serifimport,--font-family-displaytoken,.type-display-serifand.type-display-serif-smutility classes.ambient/dramaticdurations,dramatic/gentleeases,gentle/bouncy/panelSettlesprings, 7 motion presets (staggerContainer,crossfade,dialogEnter,cardHover,messageEnter,heroOverlay,heroPanel),commandPaletteMotionpreset,safeMotion()utility with test-safematchMediaguard.glass-heavy noise, right panel usesglass noise, root div applies--bg-ambient,AmbientShellmounted as first child, resize handles upgraded to invisible → accent line on hover.focus-visible:ringreplaced withglow-focus, default variant upgraded toaccent-gradient-vibrant.AmbientShell.tsx(3 CSS-animated gradient orbs, respectsprefers-reduced-motion),ActivityBars.tsx(5-bar CSS-only streaming indicator),claw-logo-minimal.svg(16×16 brand mark).glass-bypassrule (flags rawbackdrop-filter/backdrop-bluroutside.glass*),raw-glowrule (flags raw glow box-shadows outside.glow-*),CommandPaletteusage rule, exclusions forcomponents/ui/andMarkdownContent.tsx.@fontsource/instrument-serifinignoreDependencies,design-tokens.tsas entry point,ActivityBars.tsxin global ignore.Architecture impact
docs/architecture-invariants.md: noneLinked issues
N/A — foundation layer for parallel UI worktrees
Validation
pnpm lintpnpm testpnpm check:ui-contractpnpm check(all 9 sub-checks pass: lint, architecture, ui-contract, renderer-copy, i18n, dead-code, format, typecheck, test)Screenshots or recordings
Token definitions only — visual validation deferred to downstream component worktrees that consume these tokens. Glass surfaces, glow-focus, and ambient orbs are applied to the app shell and can be verified with
pnpm dev.New CI rules
glass-bypassandraw-glowenforce that all glass/glow effects go through semantic utility classes.@supports not (backdrop-filter)fallback provides solid backgrounds when backdrop-filter is unavailable.Release note
NONE.Checklist
[Feat]