Skip to content

Call notify on StateSync condition variable when resuming #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Call notify on StateSync condition variable when resuming #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6397,8 +6397,7 @@ void ProcessGDBRemote::SyncState::SetStateStopped(uint64_t stop_id) {

void ProcessGDBRemote::SyncState::DidResume() {
Log *log = GetLog(GDBRLog::Plugin);
std::lock_guard<std::mutex> guard(m_mutex);
m_state = lldb::eStateRunning;
SetStateImpl(m_stop_id, lldb::eStateRunning);
LLDB_LOG(log, "pid = {}, SyncState::{}() m_stop_id = {}, m_state = {}",
m_process.GetID(), __FUNCTION__, m_stop_id,
StateAsCString(m_state.value_or(lldb::eStateInvalid)));
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class ProcessGDBRemote : public Process,
std::optional<uint64_t> m_stop_id;
std::optional<lldb::StateType> m_state;

void SetStateImpl(uint64_t stop_id, lldb::StateType state) {
void SetStateImpl(std::optional<uint64_t> stop_id, lldb::StateType state) {
// Scope to ensure the lock is released prior to calling notify.
{
std::lock_guard<std::mutex> guard(m_mutex);
Expand Down