[LLDB] Remove an incorrectly placed cmake variable #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps throwing warnings whenever I cross-compile LLDB. The proper way to pass this variable is via -DCROSS_TOOLCHAIN_FLAGS_NATIVE and not by modifying this file.
Collaborator
|
Interesting. I probably missed some context during the past months but I believe I will let @dmpots to confirm. |
dmpots
approved these changes
Oct 9, 2025
Collaborator
There was a problem hiding this comment.
I previously came to the conclusion that we don't need this change anymore for our current setup, but didn't get around to removing it.
I tested with this patch and was able to build the amdgpu plugin successfully. Thanks for the fix!
Collaborator
Author
|
Not needed, really. I'm cross-compiling a lot these days and I didn't need to touch this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps throwing warnings whenever I cross-compile LLDB. The proper way to pass this variable is via
-DCROSS_TOOLCHAIN_FLAGS_NATIVE and not by modifying this file.