Feedback

stats-test.cpp

@@ -17,16 +17,19 @@ TEST_CASE("average is NaN for empty array") {
     auto computedStats = Statistics::ComputeStatistics({});
     //All fields of computedStats (average, max, min) must be
     //NAN (not-a-number), as defined in math.h
-    
+
     //Design the REQUIRE statement here.
     //Use http://www.cplusplus.com/reference/cmath/isnan/
+    REQUIRE(std::isnan(computedStats.average));
+    REQUIRE(std::isnan(computedStats.max));
+    REQUIRE(std::isnan(computedStats.min));
 }
 
 TEST_CASE("raises alerts when max is greater than threshold") {
     EmailAlert emailAlert;
     LEDAlert ledAlert;
     std::vector<IAlerter*> alerters = {&emailAlert, &ledAlert};
-    
+
     const float maxThreshold = 10.2;
     StatsAlerter statsAlerter(maxThreshold, alerters);
     statsAlerter.checkAndAlert({99.8, 34.2, 4.5, 6.7});

stats.cpp

@@ -1,5 +1,43 @@
 #include "stats.h"
 
-Stats Statistics::ComputeStatistics(const std::vector<___>& ) {
-    //Implement statistics here
+Stats Statistics::ComputeStatistics(const std::vector<double>& input)
+{
+    double aMin;
+    double aMax;
+    double aAverage;
+    double aSum;
+
+    if(input.empty())
+    {
+        aAverage = nan("1");
+        aMin = nan("1");
+        aMax = nan("1");
+        Stats aStat(aMin, aMax, aAverage);
+        return aStat;
+    }
+
+    //input vector is non empty, Implement statistics here
+    aMin = *min_element(input.begin(), input.end());
+    aMax = *max_element(input.begin(), input.end());
+
+    for(double elem : input)
+    {
+        aSum += elem;
+    }
+
+    aAverage = aSum/input.size();
+
+    Stats aStat(aMin, aMax, aAverage);
+    return aStat;
+}
+
+void StatsAlerter::checkAndAlert(std::vector<float> iInput)
+{
+    const float aMaxInputThreshold = *max_element(iInput.begin(), iInput.end());
+    if (aMaxInputThreshold > aMaxThreshold)
+    {
+        //Input threshold is greater than Max Threshold. Set the Alerts
+        aAlerters[0]->emailSent = true;
+        aAlerters[1]->ledGlows = true;
+    }
 }

stats.h

@@ -1,5 +1,46 @@
 #include <vector>
+#include <bits/stdc++.h>
 
-namespace Statistics {
-    Stats ComputeStatistics(const std::vector<___>& );
+class Stats
+{
+    public:
+        double min;
+        double max;
+        double average;
+
+    Stats(double imin, double imax, double iaverage): min(imin), max(imax), average(iaverage) {}
+};
+
+namespace Statistics
+{
+    Stats ComputeStatistics(const std::vector<double>& input);
 }
+
+
+class IAlerter
+{
+    public:
+        bool emailSent = false;
+        bool ledGlows = false;
+};
+
+class EmailAlert : public IAlerter
+{
+};
+
+class LEDAlert : public IAlerter
+{
+};
+
+class StatsAlerter
+{
+    private:
+    const float aMaxThreshold;
+    std::vector<IAlerter*> aAlerters;
+
+    public:
+        StatsAlerter(const float iMaxThreshold, std::vector<IAlerter*> iAlerters):
+                aMaxThreshold(iMaxThreshold), aAlerters(iAlerters) { }
+
+    void checkAndAlert(std::vector<float> iInput);
+};