Skip to content

Commit eda2e2a

Browse files
committed
perf(parser): use string comparison instead of BUILTIN_DELIMITERS_RE in config validation
1 parent d96a909 commit eda2e2a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

packages/parser/src/config.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ const normalizeConfig = (config: FlagDefinitionValue): FlagOptions =>
2525
? { type: config }
2626
: config;
2727

28-
const BUILTIN_DELIMITERS_RE = /[\s.]/;
29-
3028
export function buildConfigsAndAliases(
3129
delimiters: string[],
3230
flags: FlagsDefinition,
@@ -39,7 +37,8 @@ export function buildConfigsAndAliases(
3937

4038
const isNameInvalid = (name: string) =>
4139
delimiters.some((char) => name.includes(char)) ||
42-
BUILTIN_DELIMITERS_RE.test(name);
40+
name.includes(" ") ||
41+
name.includes(".");
4342

4443
function validateFlagOptions(name: string, options: FlagOptions) {
4544
const prefix = `Flag "${name}"`;

0 commit comments

Comments
 (0)