-
Notifications
You must be signed in to change notification settings - Fork 871
Added appearance prop samples for hiding unsupported options #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey, here’s your docs preview: https://clerk.com/docs/pr/1777 |
Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com>
|
just realizing I never clicked submit for my review :'( |
| <CodeBlockTabs options={["Sign-up", "Sign-in"]}> | ||
| ```tsx | ||
| <SignUp | ||
| routing="virtual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@royanger is routing="virtual" needed here? There was a bit of discussion around virtual nooping when not within a modal here today https://clerkinc.slack.com/archives/C079PMLTDLK/p1733954224937959
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout @alexcarpenter. I'm pretty sure that it was. needed with React Router some time ago, but I will test and see if it still is. I think it may not be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd function the same with routing="hash"?
60bcedc to
a519b2f
Compare
|
feel free to re-request me when the |
|
|
alexisintech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome addition, thank you roy 😸💖
Important
🔎 Previews:
Explanation:
Customers will want to use OAuth, Coinbase, Metamask on their web app and don't want those options showing in the sign in and up components of their Chrome Extension. This adds sample
appearanceprop styling to hide those.Checklist