Skip to content

Conversation

@royanger
Copy link
Member

@royanger royanger commented Dec 5, 2024

Explanation:

Customers will want to use OAuth, Coinbase, Metamask on their web app and don't want those options showing in the sign in and up components of their Chrome Extension. This adds sample appearance prop styling to hide those.

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1777

@royanger royanger marked this pull request as ready for review December 5, 2024 20:52
@royanger royanger requested a review from a team as a code owner December 5, 2024 20:52
Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com>
@alexisintech
Copy link
Member

just realizing I never clicked submit for my review :'(

<CodeBlockTabs options={["Sign-up", "Sign-in"]}>
```tsx
<SignUp
routing="virtual"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@royanger is routing="virtual" needed here? There was a bit of discussion around virtual nooping when not within a modal here today https://clerkinc.slack.com/archives/C079PMLTDLK/p1733954224937959

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout @alexcarpenter. I'm pretty sure that it was. needed with React Router some time ago, but I will test and see if it still is. I think it may not be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd function the same with routing="hash"?

@alexisintech alexisintech force-pushed the roy/add-appearance-config-to-sync-host-guide branch from 60bcedc to a519b2f Compare December 16, 2024 16:46
@alexisintech
Copy link
Member

feel free to re-request me when the routing thing is decided, so I can approve!

@royanger
Copy link
Member Author

routing is not needed. I removed it from this PR, and have a PR for the Chrome Extension demo removing it as well.

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome addition, thank you roy 😸💖

@royanger royanger merged commit 4b13ae7 into main Dec 16, 2024
4 checks passed
@royanger royanger deleted the roy/add-appearance-config-to-sync-host-guide branch December 16, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants