-
Notifications
You must be signed in to change notification settings - Fork 407
chore(clerk-js): Remove sessions instead of destroying the client #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d3c2f87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9f72c6b to
2d1fe74
Compare
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@1.0.13-snapshot.v6f239bb --save-exact
npm i @clerk/chrome-extension@1.2.2-snapshot.v6f239bb --save-exact
npm i @clerk/clerk-js@5.15.0-snapshot.v6f239bb --save-exact
npm i @clerk/clerk-expo@2.1.2-snapshot.v6f239bb --save-exact |
6f239bb to
3c1fab8
Compare
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
|
!snapshot |
| }); | ||
| }); | ||
|
|
||
| testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes_persist_client] })( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests 👏
Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Description
Persisting the client after sign out allows for matching a user's device with a client. This can potentially unlock many features that can build on top of this new assumption.
Since this is a very core mechanism, we would like to test it out in the wild first and then roll it out for everyone. In order to opt-in and start persisting the client after sign-out simply pass
{ persistClient: true }to the newexperimentalproperty ofClerkOptionsIn React
In Vanilla JS
SDKI-627
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change