Skip to content

Conversation

alexcarpenter
Copy link
Member

Description

Extract useCard hook for accessing logoProps and footerProps data.

Fixes SDKI-612

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: b77881a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter alexcarpenter requested a review from dstaley August 19, 2024 18:11
Base automatically changed from alexcarpenter/ui-use-parsed-appearance to ds.feat/elements-appearance-prop August 19, 2024 19:24
@@ -0,0 +1,26 @@
import { useAppearance } from '~/contexts';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments to this file describing what the hook does, when you'd want to use it, etc? Also what do you think about calling it useCardDecoration? With good docs I don't really think the name matters, but it feels like these values aren't important for the actual usage of the card, so calling the hook useCard feels a bit bigger than what the use case actually is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think here 5083de9

@alexcarpenter alexcarpenter merged commit fa908ba into ds.feat/elements-appearance-prop Aug 19, 2024
@alexcarpenter alexcarpenter deleted the alexcarpenter/ui-use-card-hook branch August 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants