-
Notifications
You must be signed in to change notification settings - Fork 394
feat(ui): Add useCard hook #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add useCard hook #3984
Conversation
|
@@ -0,0 +1,26 @@ | |||
import { useAppearance } from '~/contexts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some comments to this file describing what the hook does, when you'd want to use it, etc? Also what do you think about calling it useCardDecoration
? With good docs I don't really think the name matters, but it feels like these values aren't important for the actual usage of the card, so calling the hook useCard
feels a bit bigger than what the use case actually is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think here 5083de9
Description
Extract
useCard
hook for accessinglogoProps
andfooterProps
data.Fixes SDKI-612
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change