Skip to content

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Aug 19, 2024

Description

This PR removes the need to manually call useAppearance and pass the resulting appearance to nested AppearanceProvider contexts by calling usePartialAppearance within the provider itself. This allows us to arbitrarily nest AppearanceProviders without losing values. It also adjusts the parseAppearance call to use parsedAppearance instead, similarly to support arbitrary nesting levels.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@dstaley dstaley requested a review from alexcarpenter August 19, 2024 20:48
Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: 704273a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dstaley dstaley merged commit e880cb2 into ds.feat/elements-appearance-prop Aug 19, 2024
@dstaley dstaley deleted the ds.feat/ui-appearance-recursive branch August 19, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants