Skip to content

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Aug 20, 2024

Description

Implements socialButtonsPlacement logic.

Example:

<SignIn
  appearance={{
    layout: {
      socialButtonsPlacement: 'bottom',
    },
  }}
/>
Top Bottom
Screenshot 2024-08-20 at 4 09 33 PM Screenshot 2024-08-20 at 4 08 12 PM

Closes SDKI-559

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 97a91ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<AppearanceProvider appearance={{ layout: { unsafe_disableDevelopmentModeWarnings: devMode === 'off' } }}>
<style
dangerouslySetInnerHTML={{
__html: css,

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters. [DOM text](2) is reinterpreted as HTML without escaping meta-characters. [DOM text](3) is reinterpreted as HTML without escaping meta-characters.
@alexcarpenter alexcarpenter changed the title Alexcarpenter/sdki 559 socialbuttonsplacement feature(ui): Implement socialButtonsPlacement layout logic Aug 20, 2024
@alexcarpenter alexcarpenter changed the base branch from main to ds.feat/elements-appearance-prop August 20, 2024 20:07
@alexcarpenter alexcarpenter marked this pull request as ready for review August 20, 2024 20:18
@alexcarpenter alexcarpenter requested a review from dstaley August 20, 2024 20:18
@alexcarpenter alexcarpenter merged commit d67a3e8 into ds.feat/elements-appearance-prop Aug 21, 2024
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-559-socialbuttonsplacement branch August 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants