chore(types): Update SAML_IDPS constant for Microsoft Entra ID
#4041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9eb61c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
changed the title
SAML_IDPS for Microsoft Entra IDSAML_IDPS constant for Microsoft Entra ID
panteliselef
approved these changes
Aug 28, 2024
Member
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
I'm not familiar with the branding/terminology, feel free to ignore my comment
| }, | ||
| saml_microsoft: { | ||
| name: 'Microsoft Azure AD', | ||
| name: 'Microsoft Entra ID (Formerly AD)', |
Member
There was a problem hiding this comment.
🙃
Suggested change
| name: 'Microsoft Entra ID (Formerly AD)', | |
| name: 'Microsoft Entra ID (Azure AD)', |
Member
Author
There was a problem hiding this comment.
I tend to prefer Formerly since it denotes that AD is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
SAML_IDPSto mention Microsoft Entra ID instead of Azure AD.Microsoft Entra ID is the new name for Azure AD. The names Azure Active Directory, Azure AD, and AAD are replaced with Microsoft Entra ID.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change