Skip to content

Conversation

EmmanouelaPothitou
Copy link
Contributor

Description

Add coinbase on elements package

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: e823ea8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
Copy link
Member

@EmmanouelaPothitou Looks like there's some typing issues but, otherwise, 👍.

@dstaley
Copy link
Member

dstaley commented Aug 29, 2024

Just dropping a note that this PR is dependent on the functionality in #3940, so until that's merged CI for this one will fail.

Copy link
Member

@dstaley dstaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the API for the Coinbase flow doesn't change, this looks good to me as long as you update the changelog entry to be a bit more descriptive!

@EmmanouelaPothitou EmmanouelaPothitou merged commit 0016f9c into main Aug 31, 2024
19 checks passed
@EmmanouelaPothitou EmmanouelaPothitou deleted the emmanouela/add-coinbase-on-elements branch August 31, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants