Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Aug 29, 2024

Description

While going through all our SDK READMEs I noticed some inconsistencies, outdated information, and generally speaking too much information that already lives in the docs (as source of truth). By linking to the docs we'll make our lives easier in the future since we don't need to change information in multiple places.

Examples preview: https://github.com/clerk/javascript/blob/readme-updates/packages/nextjs/README.md

Fixes ECO-166

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 37bf442

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@clerk/chrome-extension Patch
@clerk/tanstack-start Patch
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/clerk-sdk-node Patch
@clerk/backend Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/testing Patch
@clerk/upgrade Patch
@clerk/nextjs Patch
@clerk/themes Patch
@clerk/astro Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/types Patch
@clerk/clerk-expo Patch
@clerk/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This ensures that all internal TypeScript types are generated and any dependencies between packages are resolving.

For package specific setup, refer to the `Build` section of the specific package (e.g. `packages/<package_name>/README.md#build`).
Once you're ready to make changes, run `npm run dev` from the monorepo root.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I removed the "Build" instructions from the READMEs I made this addition

[Request a Feature](https://feedback.clerk.com/roadmap)
·
[Ask a Question](https://github.com/clerk/javascript/discussions)
[Get help](https://clerk.com/contact/support?utm_source=github&utm_medium=clerk_astro)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disabled Github Discussions so no use to link to that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale file, cleanup 🧹

```shell
npm install @clerk/chrome-extension
```
1. Add `@clerk/chrome-extension` to your project:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chrome Extension docs are not live yet, so we keep it for now

## Usage

Retrieve your Backend API key from the [API Keys](https://dashboard.clerk.com/last-active?path=api-keys) screen in your Clerk dashboard and set it as an environment variable in a `.env` file:
Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active?path=api-keys) and inside the **API Keys** section copy the publishable key and secret key.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Express docs are not live yet so we keep them here for now

npm run dev
```

## Usage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Tanstack Start docs are live we can also change this

@LekoArts LekoArts merged commit 58e6754 into main Aug 29, 2024
@LekoArts LekoArts deleted the readme-updates branch August 29, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants