Skip to content

Conversation

youyou-sudo
Copy link
Contributor

@youyou-sudo youyou-sudo commented Sep 5, 2024

Update Simplified Chinese according to the latest en-US version

This is my first pr and if I've done anything wrong then I'm very sorry

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Update Simplified Chinese according to the latest en-US version
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 654e485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Major
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
Copy link
Member

tmilewski commented Sep 5, 2024

@youyou-sudo Thank you for this and congrats on your first PR! The PR looks good, but we'll just need you to add a changeset before we can go ahead and merge.

Here's more information on how to go about doing that: https://github.com/clerk/javascript/blob/main/docs/CONTRIBUTING.md#changesets

Thanks again!

@tmilewski tmilewski merged commit feb9e14 into clerk:main Sep 5, 2024
4 of 5 checks passed
@tmilewski
Copy link
Member

Thanks again, @youyou-sudo!

@youyou-sudo
Copy link
Contributor Author

Thanks again, @youyou-sudo!

You're welcome! Happy to contribute!

@youyou-sudo youyou-sudo deleted the zhCN-perfect branch September 5, 2024 15:54
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants