fix(astro): Pre-bundle client dependency for exported control components #4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4962cd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
commented
Sep 9, 2024
| // which uses <script> tags and imports nanostores will not be processed by Astro. | ||
| // This ensures @clerk/astro/client is properly processed and bundled, | ||
| // resolving runtime import issues in these components. | ||
| config.optimizeDeps?.include?.push('@clerk/astro/client'); |
Member
Author
There was a problem hiding this comment.
More info on how Astro processes <script> tags here.
The @clerk/astro/client export is imported by our control components, but Astro is not able to process it. Adding it to optimizeDeps.include will force astro to process it.
anagstef
approved these changes
Sep 10, 2024
wobsoriano
deleted the
rob/eco-188-investigate-why-csr-control-components-are-not-rendering
branch
wobsoriano
added a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR pre-bundles
@clerk/astro/clientto ensure proper processing of<script>tags and nanostore imports in our exported control components. This resolves runtime issues in development when these components are used in other projects.Resolves ECO-188
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change