feat(clerk-js,types): Supports default role on OrganizationProfile invitations
#4210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8212581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
2 times, most recently
from
eafc4b5 to
bfe9d11
Compare
LauraBeatris
changed the title
OrganizationProfileOrganizationProfile invitations
LauraBeatris
changed the title
OrganizationProfile invitations OrganizationProfile invitations
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
2 times, most recently
from
a231b1e to
df5ceb2
Compare
panteliselef
approved these changes
Sep 24, 2024
Member
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Left a few comments. If you feel they are not significant feel free to merge.
|
|
||
| let defaultRole = organizationSettings.domains.defaultRole; | ||
|
|
||
| if (!defaultRole && options?.length === 1) { |
Member
There was a problem hiding this comment.
Shouldn't this be >1 ?
"If default role doesn't exist and fetched roles exist, use the first fetched role"
Member
Author
There was a problem hiding this comment.
We're checking if there's only one role returned from FAPI here, instead of selecting the first one. This avoids making an assumption on behalf of the user, as there could be cases where they wouldn't want that one the first one as default.
packages/clerk-js/src/ui/components/OrganizationProfile/InviteMembersForm.tsx
Show resolved
Hide resolved
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
from
9ebf02b to
598a2f6
Compare
mzhong9723
approved these changes
Sep 24, 2024
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
2 times, most recently
from
e18df9c to
99ec73b
Compare
LauraBeatris
commented
Sep 24, 2024
| key: 'admin', | ||
| name: 'Admin', | ||
| description: '', | ||
| permissions: [], |
Member
Author
There was a problem hiding this comment.
Those tests were mocking with a single role, therefore initiating the field with that one instead and the assertion for "Select role" started to fail.
packages/clerk-js/src/ui/components/OrganizationProfile/InviteMembersForm.tsx
Show resolved
Hide resolved
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
from
99ec73b to
d7b4569
Compare
LauraBeatris
force-pushed
the
laura/orgs-211-set-default-role-on-organizationprofile
branch
from
d7b4569 to
8212581
Compare
LauraBeatris
deleted the
laura/orgs-211-set-default-role-on-organizationprofile
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves ORGS-211
Prepares
OrganizationProfilefor the upcomingdefault_rolechanges. When inviting a member, thedefault_rolewill be automatically selected, otherwise it falls back to the only available role.Currently behind a feature flag in the Dashboard, we're now allowing updating
default_roleregardless of whether verified domains are enabled.CleanShot.2024-09-24.at.07.57.19.mp4
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change