feat(clerk-js,backend,types): Implement "disable additional identifiers" for SAML connection #4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 884deff The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
changed the title
LauraBeatris
changed the title
LauraBeatris
changed the title
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
2ad2934 to
95cb1ca
Compare
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
2 times, most recently
from
1f1c0a7 to
f559891
Compare
NicolasLopes7
changed the title
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
2 times, most recently
from
2245874 to
e70b619
Compare
LauraBeatris
requested changes
Sep 24, 2024
packages/clerk-js/src/ui/components/UserProfile/AccountPage.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/EmailsSection.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/__tests__/AccountPage.test.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/Web3Section.tsx
Outdated
Show resolved
Hide resolved
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
a011592 to
3b4e025
Compare
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
3b4e025 to
bd264f3
Compare
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
d53aba1 to
1097858
Compare
packages/clerk-js/src/ui/components/UserProfile/PhoneSection.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/Web3Section.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/__tests__/AccountPage.test.tsx
Outdated
Show resolved
Hide resolved
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
c350858 to
6129ced
Compare
NicolasLopes7
force-pushed
the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
from
6129ced to
884deff
Compare
LauraBeatris
approved these changes
Sep 25, 2024
NicolasLopes7
deleted the
nicolas/orgs-138-disable-adding-additional-identifieraccount-saml
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
…rs" for SAML connection (#4211)
NicolasLopes7
added a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
9 tasks
NicolasLopes7
added a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
NicolasLopes7
added a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
NicolasLopes7
added a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
NicolasLopes7
added a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
LauraBeatris
pushed a commit
that referenced
this pull request
Aug 20, 2025
…s additional identifications - Add `shouldAllowCreation` prop to PasskeySection component to control visibility - Update SecurityPage to check enterprise account restrictions and pass shouldAllowCreation prop - Hide entire PasskeySection when user has active enterprise account with disableAdditionalIdentifications flag This change prevents users from adding passkeys when their enterprise connection explicitly disables additional identification methods, maintaining security policies set by enterprise administrators. This commit follows a simillar pattern introduced earlier on this PR: #4211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new feature for SAML connections. On the dashboard, users will be able to turn on/off a new flag called
disable_additional_identifications. This is responsible for blocking the users to add any new identification other than their saml account. This pull request adds the newsaml_connectionfield on thesaml_accounts, and perform a logical check on the<UserProfile />to conditional render the other sections (and add buttons).Checklist
npm testruns as expected.npm run buildruns as expected.Type of change