fix(clerk-js): Handle gracefully Coinbase Wallet initial configuration #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanioxaris
requested review from
anagstef,
nikosdouvlis,
octoper and
panteliselef
🦋 Changeset detectedLatest commit: 9041cbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chanioxaris
force-pushed
the
haris/user-746-first-time-coinbase-wallet-user-onboarding-fails-to-complete
branch
from
f1ecfaa to
96f4112
Compare
octoper
approved these changes
Sep 25, 2024
anagstef
approved these changes
Sep 25, 2024
nikospapcom
approved these changes
Sep 25, 2024
| // Coinbase Wallet from scratch in order to authenticate, the initial generate | ||
| // signature request to be rejected. For this reason we retry the request once more | ||
| // in order for the flow to be able to be completed successfully. | ||
| if (provider === 'coinbase_wallet' && err.message === 'Request rejected') { |
Member
There was a problem hiding this comment.
Is there anything else we can check against ? Maybe a code ? Does this come back from the coinbase sdk ?
Member
Author
There was a problem hiding this comment.
We can also check the error type, but that means we will have to import the type from the coinbase sdk globally and i believe lose our lazy loading ability
Member
Author
There was a problem hiding this comment.
Replaced with an error code check instead of the message
chanioxaris
force-pushed
the
haris/user-746-first-time-coinbase-wallet-user-onboarding-fails-to-complete
branch
from
96f4112 to
98c40a0
Compare
There is a chance that as a first time visitor when you try to setup and use the Coinbase Wallet from scratch in order to authenticate, the initial generate signature request to be rejected. For this reason we retry the request once more in order for the flow to be able to be completed successfully.
chanioxaris
force-pushed
the
haris/user-746-first-time-coinbase-wallet-user-onboarding-fails-to-complete
branch
from
98c40a0 to
9041cbe
Compare
chanioxaris
deleted the
haris/user-746-first-time-coinbase-wallet-user-onboarding-fails-to-complete
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a chance that as a first time visitor when you try to setup and use the Coinbase Wallet from scratch in order to authenticate, the initial generate signature request to be rejected. For this reason we retry the request once more in order for the flow to be able to be completed successfully.
Before
before.mov
After
after.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change