DO NOT MERGE - Izaak CI test #4231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.
Turns out someone in the call chain was redirecting before we hit handshake. That's great!
To keep them all straight, I made a matrix: https://docs.google.com/spreadsheets/d/15OVcrHz_tj1K9XSfgPDzEQbjQLqn7XotJaZdZbLrLI4/edit?gid=0#gid=0
In my judgement, the time to value tradeoff isn't there. It adds too much time.
#3977 (comment) #3977 (comment) (doing it this way because I have a big enough local change that it's not worth trying to preserve the github-ui-created commits)
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Rather than logging them.
Thanks @LauraBeatris! https://github.com/pillarjs/path-to-regexp/blob/df39d6c30b2a8bdc9b8bda186f658cc89d47e44c/src/index.ts#discussion_r1761524255 Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Header-based auth indicates a non-browser actor, which means they don't have the __client cookie and a handshake won't be useful.
🦋 Changeset detectedLatest commit: e62e239 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #3977
The integration tests aren't running on that PR. This is a duplicate, to test if the integration tests not running is a result of the state of that branch (as the forums hint), or an issue with the new integration tests.