-
Notifications
You must be signed in to change notification settings - Fork 407
feat(fastify)!: Support Fastify v5 #4270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: bf3208c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!allow-major |
|
@LekoArts do we also want to update the root (or maybe we can remove it altogether) |
|
@brkalow Good catch! That's not needed at the root since I've put it into the plugin. Weird that it was there in the first place |
brkalow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! One question about changes to the playground dependencies
| "@clerk/backend": "file:.yalc/@clerk/backend", | ||
| "@clerk/fastify": "file:.yalc/@clerk/fastify", | ||
| "@clerk/shared": "file:.yalc/@clerk/shared", | ||
| "@clerk/types": "file:.yalc/@clerk/types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we retain yalc usage here for the playground?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because when you use clerk-dev-cli or secco it gets in the way. If we want to dogfood the dev CLI we need to remove yalc ;)
|
Hello! 👋 Steps to reproduce the issue Maybe the CI did not picked up the latest changes and build the new package with the old code 🤔 Please let me know if i can help or submit a PR i would appreciate a little bit of guidance for it Thanks. |
|
@jvelezpo we did not publish this update to NPM yet. Maybe tomorrow. For now, you can try the canary version
|
|
Amazing |
|
@jvelezpo That PR has been released, you can upgrade now with |
Description
This PR will trigger a new major release for
@clerk/fastify. The reason is that Fastify v5 isn't backwards compatible with our current plugin as we allow Node.js 18 and they now require Node 20. So we need to bump ourengines.Therefore the new major version of
@clerk/fastifywill only support Fastify v5, users of older versions need to stick with the current major version.Fixes #4229
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change