Skip to content

fix(backend): Expose permissions field for OrganizationMembership #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(backend): Expose permissions field for OrganizationMembership #4310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-kids-attack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/backend": patch
Copy link
Member

@brkalow brkalow Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature or bug fix? 🤔

Suggested change
"@clerk/backend": patch
"@clerk/backend": minor

Copy link
Member Author

@dstaley dstaley Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that we were missing a field that should have been there eight months ago, so it feels like a bug rather than a feature.

---

Expose `permissions` field for `OrganizationMembership` resource
2 changes: 2 additions & 0 deletions packages/backend/src/api/resources/OrganizationMembership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export class OrganizationMembership {
constructor(
readonly id: string,
readonly role: OrganizationMembershipRole,
readonly permissions: string[],
readonly publicMetadata: OrganizationMembershipPublicMetadata = {},
readonly privateMetadata: OrganizationMembershipPrivateMetadata = {},
readonly createdAt: number,
Expand All @@ -18,6 +19,7 @@ export class OrganizationMembership {
return new OrganizationMembership(
data.id,
data.role,
data.permissions,
data.public_metadata,
data.private_metadata,
data.created_at,
Expand Down
Loading