-
Notifications
You must be signed in to change notification settings - Fork 405
feat(localization): Add en-GB #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b65aed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijxy Thank you for this! Please just update the major changeset to minor, and we should be good to go!
anagstef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the changes of generate.ts file.
|
@anagstef @tmilewski Apologies for the delay–I have updated as per comments and extracted the changed words into a little dictionary object so it is easier to see what is actually changed. The tl;dr is that now the enGB locale data should automatically stay up to date with any changes to enUS. 🎉 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@tmilewski is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ijxy! We had a discussion internally and thought it'd be better to keep things consistent as well as not increase run-time work. As-such, I've applied the values in your work to the existing en-US file.
Thanks for your contribution!
Co-authored-by: Tom Milewski <me@tm.codes>
Description
Replaces a couple of "Americanisms" with their British versions:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change