Skip to content

Conversation

@ijxy
Copy link
Contributor

@ijxy ijxy commented Oct 10, 2024

Description

Replaces a couple of "Americanisms" with their British versions:

  • authorize with authorise
  • organization with organisation

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: b65aed0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijxy Thank you for this! Please just update the major changeset to minor, and we should be good to go!

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the changes of generate.ts file.

@ijxy
Copy link
Contributor Author

ijxy commented Oct 25, 2024

@anagstef @tmilewski Apologies for the delay–I have updated as per comments and extracted the changed words into a little dictionary object so it is easier to see what is actually changed.

The tl;dr is that now the enGB locale data should automatically stay up to date with any changes to enUS. 🎉

@ijxy ijxy requested review from anagstef and tmilewski October 25, 2024 16:36
@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ❌ Failed (Inspect) Dec 5, 2024 5:43pm

@vercel
Copy link

vercel bot commented Dec 5, 2024

@tmilewski is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ijxy! We had a discussion internally and thought it'd be better to keep things consistent as well as not increase run-time work. As-such, I've applied the values in your work to the existing en-US file.

Thanks for your contribution!

@tmilewski tmilewski merged commit 6fdffaf into clerk:main Dec 5, 2024
7 of 23 checks passed
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Tom Milewski <me@tm.codes>
@ijxy ijxy deleted the feat/localizations/add-en-GB branch February 19, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants